Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 23567015: Reorder ViewHostMsg_TextInputTypeChanged IPC parameters. (Closed)

Created:
7 years, 3 months ago by yoichio
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Reorder ViewHostMsg_TextInputTypeChanged IPC parameters. This CL is to intent that we have two different fields that represent input field attributes. BUG=244688 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221088

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/render_widget.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yoichio
Could you stamp this?
7 years, 3 months ago (2013-09-02 09:15:27 UTC) #1
Yohei Yukawa
lgtm
7 years, 3 months ago (2013-09-02 09:25:34 UTC) #2
yoichio
Add OWNERs. sky@ for content/browser/*. palmer@ for content/common/view_messages.h. jamesr@ for content/renderer/*. Could you please review?
7 years, 3 months ago (2013-09-02 09:35:00 UTC) #3
sky
LGTM
7 years, 3 months ago (2013-09-03 16:10:06 UTC) #4
palmer
LGTM
7 years, 3 months ago (2013-09-03 18:12:46 UTC) #5
jamesr
lgtm
7 years, 3 months ago (2013-09-03 18:20:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/23567015/1
7 years, 3 months ago (2013-09-03 22:42:31 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 00:37:02 UTC) #8
Message was sent while issue was closed.
Change committed as 221088

Powered by Google App Engine
This is Rietveld 408576698