Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 23567012: Use fast path of mailbox generation in RGVAF::CreateTextures. (Closed)

Created:
7 years, 3 months ago by wuchengli
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org, Owen Lin, Ami GONE FROM CHROMIUM
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use fast path of mailbox generation in RGVAF::CreateTextures. This reduces the latency of CreateTextures (8 textures) from around 1000ms to 1ms for HW decode WebRTC on Chromebook Daisy. GLES2Implementation doesn't currently have the right hook to make mailbox generation fast, though WebGraphicsContext3DCommandBufferImpl does. The fast path for mailbox generation only exists in content, that GLES2Implementation, in gpu, can't directly access. So GLES2Implementation has to go through command buffers, which is bad for round-trips. BUG=170345 TEST=Run http://apprtc.appspot.com/?debug=loopback on Chromebook Daisy. Play local hardware-accelerated videos on Daisy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221285

Patch Set 1 : #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
wuchengli
7 years, 3 months ago (2013-09-02 05:48:45 UTC) #1
Ami GONE FROM CHROMIUM
I'm not competent to review this change's meat since I don't understand any of the ...
7 years, 3 months ago (2013-09-03 18:55:05 UTC) #2
piman
LGTM, maybe add a comment so that someone doesn't try to "clean up" for consistency.
7 years, 3 months ago (2013-09-03 20:19:28 UTC) #3
wuchengli
Added comment. Submitting now.
7 years, 3 months ago (2013-09-04 07:28:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wuchengli@chromium.org/23567012/9001
7 years, 3 months ago (2013-09-04 16:36:05 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 22:50:30 UTC) #6
Message was sent while issue was closed.
Change committed as 221285

Powered by Google App Engine
This is Rietveld 408576698