Issue 23567010: Fixing a problem introduced when "Unknown" certs were renamed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23567010: Fixing a problem introduced when "Unknown" certs were renamed (Closed)

Created:
7 years, 3 months ago by Greg Spencer (Chromium)

Modified:
7 years, 3 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, dbeam+watch-options_chromium.org, cbentzel+watch_chromium.org, tfarina, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing a problem introduced when "Unknown" certs were renamed to "Other" certs. The rename was apparently not quite finished, so some strings were not found at runtime anymore. This fixes that by finishing the rename of associated strings. (TBR'ing trivial rename of enum) TBR=sky@chromium.org BUG=243471 TEST=Ran on device and verified that dialog now asks the intended question. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220770

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -24 lines)			Patch
M	chrome/app/generated_resources.grd	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options/certificate_manager.html	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/certificate_manager_handler.cc	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/common/net/x509_certificate_model_openssl.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/net/x509_certificate_model_unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/third_party/mozilla_security_manager/nsNSSCertHelper.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/network/onc/onc_certificate_importer_impl_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/cert/cert_type.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/cert/x509_certificate_nss.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Greg Spencer (Chromium)

James, could you take a look at this please? Seems that someone just forgot to ...

7 years, 3 months ago (2013-08-30 23:33:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gspencer@chromium.org/23567010/1

7 years, 3 months ago (2013-08-30 23:39:01 UTC) #3

Message was sent while issue was closed.

Change committed as 220770

Expand Messages | Collapse Messages