Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 23566019: Adding range checking to setSelection and setComposingRegion. (Closed)

Created:
7 years, 3 months ago by aurimas (slooooooooow)
Modified:
7 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Adding range checking to setSelection and setComposingRegion. Adding an early return in setSelection to match BaseInputConnection. Adding clipping in setComposingRegion to match BaseInputConnection. BUG=286348 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/AdapterInputConnection.java View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aurimas (slooooooooow)
Hey Ted, Please take a look at this CL. Thanks, Aurimas
7 years, 3 months ago (2013-09-06 17:39:16 UTC) #1
Ted C
lgtm
7 years, 3 months ago (2013-09-06 17:48:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/23566019/1
7 years, 3 months ago (2013-09-06 17:53:51 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 22:33:15 UTC) #4
Message was sent while issue was closed.
Change committed as 221800

Powered by Google App Engine
This is Rietveld 408576698