Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 23565003: [Files.app] Hide the shortcut list when the drive is disabled. (Closed)

Created:
7 years, 3 months ago by yoshiki
Modified:
7 years, 3 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[Files.app] Hide the shortcut list when the drive is disabled. All shourtcuts target to drive. So they should not be available when the drive is disabled. BUG=280152 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220516

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -11 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +3 lines, -1 line 2 comments Download
M chrome/browser/resources/file_manager/js/navigation_list.js View 6 chunks +62 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yoshiki
@hirono, could you take a look? Thanks.
7 years, 3 months ago (2013-08-30 02:15:27 UTC) #1
hirono
On 2013/08/30 02:15:27, yoshiki wrote: > @hirono, could you take a look? Thanks. lgtm with ...
7 years, 3 months ago (2013-08-30 03:38:32 UTC) #2
hirono
7 years, 3 months ago (2013-08-30 03:38:40 UTC) #3
hirono
https://codereview.chromium.org/23565003/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/23565003/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode1983 chrome/browser/resources/file_manager/js/file_manager.js:1983: var isDriveEnabled = self.isDriveEnabled(); Is it better to use ...
7 years, 3 months ago (2013-08-30 03:39:10 UTC) #4
yoshiki
https://codereview.chromium.org/23565003/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/23565003/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode1983 chrome/browser/resources/file_manager/js/file_manager.js:1983: var isDriveEnabled = self.isDriveEnabled(); On 2013/08/30 03:39:10, hirono wrote: ...
7 years, 3 months ago (2013-08-30 03:41:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/23565003/1
7 years, 3 months ago (2013-08-30 03:44:05 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 06:30:00 UTC) #7
Message was sent while issue was closed.
Change committed as 220516

Powered by Google App Engine
This is Rietveld 408576698