Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 23564004: rAc: fix appearance of CVC input in autofill suggestion (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
index 7ff0aabda44785b26d73e970570a1f304b02c471..157f141a33b46cc69fdd5636df65d0d6ef546a2f 100644
--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
@@ -152,7 +152,10 @@ void DrawArrow(gfx::Canvas* canvas,
// expand a single child).
class SectionRowView : public views::View {
public:
- SectionRowView() {}
+ SectionRowView() {
+ set_border(views::Border::CreateEmptyBorder(10, 0, 0, 0));
+ }
+
virtual ~SectionRowView() {}
// views::View implementation:
@@ -170,7 +173,8 @@ class SectionRowView : public views::View {
}
}
- return gfx::Size(width, height);
+ gfx::Insets insets = GetInsets();
+ return gfx::Size(width + insets.width(), height + insets.height());
}
virtual void Layout() OVERRIDE {
@@ -1066,7 +1070,7 @@ AutofillDialogViews::SuggestionView::SuggestionView(
// TODO(estade): get the sizing and spacing right on this textfield.
decorated_->SetVisible(false);
- decorated_->set_default_width_in_chars(10);
+ decorated_->set_default_width_in_chars(15);
label_container->AddChildView(decorated_);
// TODO(estade): need to get the line height right.
@@ -1075,8 +1079,7 @@ AutofillDialogViews::SuggestionView::SuggestionView(
label_line_2_->SetMultiLine(true);
AddChildView(label_line_2_);
- // TODO(estade): do something about this '2'.
- SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical, 0, 2, 0));
+ SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical, 0, 0, 0));
}
AutofillDialogViews::SuggestionView::~SuggestionView() {}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698