components/autofill/content/common/autofill_messages.h - Issue 235623002: Password manager internals page: Improve security

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 235623002: Password manager internals page: Improve security (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Pass a string16 by a const ref Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index c734cd25de8e4d9d3ae1cf4a57c14ef86503a0ec..93026b5edc6b8834c786d159daa2885d18a5dee5 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -190,7 +190,10 @@ IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsRendered,

IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormSubmitted,

autofill::PasswordForm /* form */)

-// Notification that logs during saving the password have been gathered.

+// Sends |log| to browser for displaying to the user. Only strings passed as an

+// argument to methods overriding SavePasswordProgressLogger::SendLog may become

+// |log|, because those are guaranteed to be sanitized. Never pass a free-form

+// string as |log|.

IPC_MESSAGE_ROUTED1(AutofillHostMsg_RecordSavePasswordProgress,

std::string /* log */)

« no previous file with comments | « no previous file | components/autofill/core/common/save_password_progress_logger.h » ('j') | no next file with comments »