add uncached Function::New

src/apinatives.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 19 matching lines @@
 // loaded.
 
 
 function CreateDate(time) {
   var date = new $Date();
   date.setTime(time);
   return date;
 }
 
 
 var kApiFunctionCache = new InternalArray();

[yhirano, 2013/09/06 15:39:12]

I think we should use Object here because serial_number can grow to a very large
number by repetitive Function::New calls.

[dcarney, 2013/09/06 17:59:49]

okay, i can just set the serial_number for objects that aren't going to be
cached to be 0 or -1 or something, then we won't have a problem

 var functionCache = kApiFunctionCache;
 
 
 function Instantiate(data, name) {
   if (!%IsTemplate(data)) return data;
   var tag = %GetTemplateField(data, kApiTagOffset);
   switch (tag) {
     case kFunctionTag:
       return InstantiateFunction(data, name);
     case kNewObjectTag:
@@ skipping 16 matching lines @@
   // if we need to bail out from a stack overflow.
   var cache = kApiFunctionCache;
   var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset);
   var isFunctionCached =
    (serialNumber in cache) && (cache[serialNumber] != kUninitialized);
   if (!isFunctionCached) {
     try {
       cache[serialNumber] = null;
       var fun = %CreateApiFunction(data);
       if (name) %FunctionSetName(fun, name);
-      cache[serialNumber] = fun;
       var flags = %GetTemplateField(data, kApiFlagOffset);
+      var doNotCache = flags & (1 << kDoNotCacheBit);
+      if (!doNotCache) cache[serialNumber] = fun;
       if (flags & (1 << kRemovePrototypeBit)) {
         %FunctionRemovePrototype(fun);
       } else {
         var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset);
         // Note: Do not directly use an object template as a condition, our
         // internal ToBoolean doesn't handle that!
         fun.prototype = typeof prototype === 'undefined' ?
             {} : Instantiate(prototype);
         if (flags & (1 << kReadOnlyPrototypeBit)) {
           %FunctionSetReadOnlyPrototype(fun);
         }
         %SetProperty(fun.prototype, "constructor", fun, DONT_ENUM);
         var parent = %GetTemplateField(data, kApiParentTemplateOffset);
         // Note: Do not directly use a function template as a condition, our
         // internal ToBoolean doesn't handle that!
         if (!(typeof parent === 'undefined')) {
           var parent_fun = Instantiate(parent);
           %SetPrototype(fun.prototype, parent_fun.prototype);
         }
       }
       ConfigureTemplateInstance(fun, data);
+      if (doNotCache) return fun;
     } catch (e) {
       cache[serialNumber] = kUninitialized;
       throw e;
     }
   }
   return cache[serialNumber];
 }
 
 
 function ConfigureTemplateInstance(obj, data) {
@@ skipping 20 matching lines @@
             obj, name, getter, setter, attribute, access_control);
       } else {
         throw "Bad properties array";
       }
       i += length + 1;
     }
   } finally {
     if (requires_access_checks) %EnableAccessChecks(obj);
   }
 }