Issue 2356093002: Move navigation specific logic in wilSendRequest to a separate method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2356093002: Move navigation specific logic in wilSendRequest to a separate method

Created:
4 years, 3 months ago by Charlie Harrison

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews, nasko+codewatch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move navigation specific logic in wilSendRequest to a separate method

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -25 lines)			Patch
	M	content/renderer/render_frame_impl.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	content/renderer/render_frame_impl.cc	View		7 chunks	+43 lines, -25 lines	0 comments	Download

Dependent Patchsets:

Issue 2350363005 Patch 1

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Charlie Harrison

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

4 years, 3 months ago (2016-09-21 03:54:41 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2356093002/1

4 years, 3 months ago (2016-09-21 03:55:01 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 3 months ago (2016-09-21 04:17:44 UTC) #3

commit-bot: I haz the power

4 years, 3 months ago (2016-09-21 04:17:45 UTC) #4

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages