Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 23558007: Use apps::IsAppShimsEnabled instead of kEnableAppShims (Closed)

Created:
7 years, 3 months ago by jackhou1
Modified:
7 years, 3 months ago
Reviewers:
tapted, Nico
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Use apps::IsAppShimsEnabled instead of kEnableAppShims Currently the main menu is only modified for app windows when --enable-app-shims is enabled. This change enables modifying the main menu whenever app shims are enabled (i.e. when the app launcher is enabled). BUG=168080, 276052 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/app_controller_mac.mm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jackhou1
7 years, 3 months ago (2013-09-06 05:42:40 UTC) #1
jackhou1
thakis, please review for OWNERS
7 years, 3 months ago (2013-09-06 05:43:29 UTC) #2
tapted
7 years, 3 months ago (2013-09-06 05:50:17 UTC) #3
tapted
lgtm
7 years, 3 months ago (2013-09-06 05:50:31 UTC) #4
Nico
Code lgtm (go ahead and land), but I don't understand the CL description. How does ...
7 years, 3 months ago (2013-09-08 20:09:11 UTC) #5
jackhou1
On 2013/09/08 20:09:11, Nico wrote: > Code lgtm (go ahead and land), but I don't ...
7 years, 3 months ago (2013-09-08 23:49:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/23558007/1
7 years, 3 months ago (2013-09-08 23:49:23 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 04:13:26 UTC) #8
Message was sent while issue was closed.
Change committed as 221974

Powered by Google App Engine
This is Rietveld 408576698