Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6369)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 23557004: Save password bubble pops up automatically (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor change Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.h
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.h b/chrome/browser/ui/views/location_bar/location_bar_view.h
index f846263ee5ca6f42175fc61baafb1a53c878f243..83e2872ee60848e83458d6f0747c88b9593a2a0f 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.h
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.h
@@ -383,9 +383,18 @@ class LocationBarView : public LocationBar,
return is_popup_mode_ ? kPopupEdgeThickness : kNormalEdgeThickness;
}
- // Update the visibility state of the Content Blocked icons to reflect what is
- // actually blocked on the current page.
- void RefreshContentSettingViews();
+ // Updates the visibility state of the Content Blocked icons to reflect what
+ // is actually blocked on the current page. Calling this function should
+ // always eventually be followed by calling Layout() and then
+ // UpdateContentSettingViewsPostLayout(), to ensure the icons can completely
+ // update their states.
+ void UpdateContentSettingViewsPreLayout();
+
+ // Updates after the correct screen coordinates have been set for icons.
+ // Allows content setting icons to perform any updating which can't complete
+ // until after the icons have been correctly laid out. This should be called
+ // after UpdateContentSettingViewsPreLayout() and a subsequent Layout().
+ void UpdateContentSettingViewsPostLayout();
// Delete all page action views that we have created.
void DeletePageActionViews();

Powered by Google App Engine
This is Rietveld 408576698