Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 23553007: Treat headers and HTTP status text as Latin-1 (Closed)

Created:
7 years, 3 months ago by davidben
Modified:
7 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jungshik at Google
Visibility:
Public.

Description

Treat headers and HTTP status text as Latin-1 We currently decode them as UTF-8, but they should be interpreted as Latin-1. (XHR specs the relevant parameters as WebIDL ByteString.) For response headers, this matches Firefox, IE, Opera 12, and Safari. For status text, this matches Firefox nightly, IE, Opera 12, and Opera. For request headers, this matches Firefox nightly, Opera 12, and Safari. Preparatory Blink CL disabled a layout test: https://src.chromium.org/viewvc/blink?revision=157238&view=revision This CL will be followed by a Blink CL to fix and re-enable the test, throw exception on non-Latin-1 setRequestHeader argument, and add a new layout test to verify this behavior. BUG=276769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222127

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M webkit/child/weburlloader_impl.cc View 6 chunks +20 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
davidben
darin: You were the last person to touch this (a long time ago), and I'm ...
7 years, 3 months ago (2013-09-06 18:53:39 UTC) #1
darin (slow to review)
LGTM
7 years, 3 months ago (2013-09-06 19:07:41 UTC) #2
darin (slow to review)
+cc:jshin
7 years, 3 months ago (2013-09-06 19:08:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/23553007/2001
7 years, 3 months ago (2013-09-09 17:14:12 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-09 17:21:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/23553007/2001
7 years, 3 months ago (2013-09-09 18:20:51 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 23:27:59 UTC) #7
Message was sent while issue was closed.
Change committed as 222127

Powered by Google App Engine
This is Rietveld 408576698