Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: content/browser/renderer_host/media/video_capture_manager.cc

Issue 23551011: From Video Capture, abolish OnFrameInfo and enable resolution changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes from bbudge Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/video_capture_manager.cc
diff --git a/content/browser/renderer_host/media/video_capture_manager.cc b/content/browser/renderer_host/media/video_capture_manager.cc
index 9d4d3d5e6fd4bfa532dfcd37098566f83b22959d..b271583a3e13c18da5826d55de12a1f98e73f25b 100644
--- a/content/browser/renderer_host/media/video_capture_manager.cc
+++ b/content/browser/renderer_host/media/video_capture_manager.cc
@@ -183,20 +183,20 @@ void VideoCaptureManager::DoStartDeviceOnDeviceThread(
}
void VideoCaptureManager::StartCaptureForClient(
- const media::VideoCaptureParams& capture_params,
+ const media::VideoCaptureParams& params,
base::ProcessHandle client_render_process,
VideoCaptureControllerID client_id,
VideoCaptureControllerEventHandler* client_handler,
const DoneCB& done_cb) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
DVLOG(1) << "VideoCaptureManager::StartCaptureForClient, ("
- << capture_params.width
- << ", " << capture_params.height
- << ", " << capture_params.frame_rate
- << ", #" << capture_params.session_id
+ << params.requested_format.width
+ << ", " << params.requested_format.height
+ << ", " << params.requested_format.frame_rate
+ << ", #" << params.session_id
<< ")";
- DeviceEntry* entry = GetOrCreateDeviceEntry(capture_params.session_id);
+ DeviceEntry* entry = GetOrCreateDeviceEntry(params.session_id);
if (!entry) {
done_cb.Run(base::WeakPtr<VideoCaptureController>());
return;
@@ -210,11 +210,12 @@ void VideoCaptureManager::StartCaptureForClient(
<< entry->stream_type << ", id = " << entry->id << ")";
media::VideoCaptureCapability params_as_capability;
- params_as_capability.width = capture_params.width;
- params_as_capability.height = capture_params.height;
- params_as_capability.frame_rate = capture_params.frame_rate;
- params_as_capability.session_id = capture_params.session_id;
- params_as_capability.frame_size_type = capture_params.frame_size_type;
+ params_as_capability.session_id = params.session_id;
+ params_as_capability.width = params.requested_format.width;
+ params_as_capability.height = params.requested_format.height;
+ params_as_capability.frame_rate = params.requested_format.frame_rate;
+ params_as_capability.frame_size_type =
+ params.requested_format.frame_size_type;
device_loop_->PostTask(FROM_HERE, base::Bind(
&VideoCaptureManager::DoStartDeviceOnDeviceThread, this,
@@ -226,7 +227,7 @@ void VideoCaptureManager::StartCaptureForClient(
entry->video_capture_controller->AddClient(client_id,
client_handler,
client_render_process,
- capture_params);
+ params);
}
void VideoCaptureManager::StopCaptureForClient(

Powered by Google App Engine
This is Rietveld 408576698