Issue 23551010: Removing remaining spurrious NULL checks on m_frame in FrameView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23551010: Removing remaining spurrious NULL checks on m_frame in FrameView (Closed)

Created:
7 years, 3 months ago by bokan

Modified:
7 years, 3 months ago

Reviewers:
caseq, kenneth.r.christiansen, abarth-chromium

CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, eae+blinkwatch

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Removing remaining spurrious NULL checks on m_frame in FrameView Amendment to CL: https://codereview.chromium.org/23483024 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157387

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -13 lines)			Patch
	M	Source/core/page/FrameView.cpp	View		4 chunks	+9 lines, -13 lines	0 comments	Download

Total messages: 7 (0 generated)

bokan

Was working on the same refactoring :), here's a few extra checks that look like ...

7 years, 3 months ago (2013-09-05 20:23:10 UTC) #1

kenneth.r.christiansen

lgtm given that frame is always present... the CL doesn't refer to the "original CL" ...

7 years, 3 months ago (2013-09-05 20:36:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/23551010/1

7 years, 3 months ago (2013-09-06 19:26:12 UTC) #6

Message was sent while issue was closed.

Change committed as 157387