Fix typefacesMatchesFamily to treat family string as UTF8

Fix typefacesMatchesFamily to treat family string as UTF8

Fix bug in FontCacheSkiaWin::typefacesMatchesFamily where the family
name returned by skia was converted to cstring without setting the
encoding to UTF8.

This was caught by fast/text/backslash-to-yen-sign-euc.html and is
only applicable if the GDI code path is disabled.

BUG=249099
R=bungeman@google.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157985

[bungeman-skia, 2013-09-18 17:29:04]

As far as fixing the bug, lgtm. I must confess that I'm somewhat ignorant of
AtomicString so I'm not sure if there is any significant cost to this or if it
could be avoided.

[leviw_travelin_and_unemployed, 2013-09-18 20:07:45]

This LGTM, but it sounds like you've already identified another instance of
this... Please file a bug to cover this class of errors.

https://codereview.chromium.org/23549036/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/skia/FontCacheSkiaWin.cpp (right):

https://codereview.chromium.org/23549036/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/skia/FontCacheSkiaWin.cpp:167: if
(equalIgnoringCase(family,
AtomicString::fromUTF8(actualFamily.fString.c_str()))) {
Talked to eseidel. He mentioned that we may want to be wrapping the SkTypeface
in an object we deal with to avoid other mis-comparisons with c_str.

[eae, 2013-09-18 20:10:20]

On 2013/09/18 20:07:45, Levi wrote:
> This LGTM, but it sounds like you've already identified another instance of
> this... Please file a bug to cover this class of errors.
> 
>
https://codereview.chromium.org/23549036/diff/1/Source/core/platform/graphics...
> File Source/core/platform/graphics/skia/FontCacheSkiaWin.cpp (right):
> 
>
https://codereview.chromium.org/23549036/diff/1/Source/core/platform/graphics...
> Source/core/platform/graphics/skia/FontCacheSkiaWin.cpp:167: if
> (equalIgnoringCase(family,
> AtomicString::fromUTF8(actualFamily.fString.c_str()))) {
> Talked to eseidel. He mentioned that we may want to be wrapping the SkTypeface
> in an object we deal with to avoid other mis-comparisons with c_str.

I'll file a buf and see about adding a constructor that takes an SkString.
Thanks!

[commit-bot: I haz the power, 2013-09-18 20:10:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eae@chromium.org/23549036/1

[commit-bot: I haz the power, 2013-09-18 23:10:23]

Change committed as 157985