Clean up JSON Schema Compiler.

Clean up JSON Schema Compiler's pylint errors.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222389

[dhnishi (use Chromium), 2013-09-09 22:55:43]

@kalman

I did some clean up of the JSON Schema Compiler, because I noticed a few nits
while I was working on the feature generator. Once I started, though, I decided
I might as well go the whole way and tackled some of the pylint errors.

Most of it is pretty trivial things -- removing unnecessary imports, unnecessary
semi-colons, non-standard indentation. There were a couple of questions I had
for some other bits, though.

The big question mark for me here is the dart_test enum test. The enum.dart file
it was supposed to compare against was never uploaded in its original patch, and
the test was never run because it was accidentally named testEvents, rather than
testEnum, giving a duplicate definition for testEvents. I wasn't sure of the
intended output, so I just generated the enum.dart off the enum.idl and hoped it
was right.

Do you know if that is the expected output?

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/co...
File tools/json_schema_compiler/compiler.py (left):

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/co...
tools/json_schema_compiler/compiler.py:81: # The output filename must match the
input filename for gyp to deal with it
I removed this bit because the code was never used, but I wasn't sure if there
was missing functionality here or not, based on the comments.

[not at google - send to devlin, 2013-09-09 23:46:30]

+benwells for the dart question.

[not at google - send to devlin, 2013-09-09 23:50:25]

Thanks for the cleanup, lgtm. Wait for Ben to get back about the dart test
though.

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/cc...
File tools/json_schema_compiler/cc_generator.py (right):

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/cc...
tools/json_schema_compiler/cc_generator.py:10: 
now that I know about the Python PEP8 thing, I know that each top-level entity
(global function, class declaration) should have 2 blank lines between it. So
you might as well go through and fix those in the files you are touching, too.

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/co...
File tools/json_schema_compiler/compiler.py (left):

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/co...
tools/json_schema_compiler/compiler.py:81: # The output filename must match the
input filename for gyp to deal with it
On 2013/09/09 22:55:43, Daniel Nishi wrote:
> I removed this bit because the code was never used, but I wasn't sure if there
> was missing functionality here or not, based on the comments.

Eh who knows. Delete SGTM.

[benwells, 2013-09-10 00:53:00]

lgtm

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/da...
File tools/json_schema_compiler/dart_generator_test.py (right):

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/da...
tools/json_schema_compiler/dart_generator_test.py:64: self._RunTest('enums')
Could you just delete this test and its associated idl file? The output looks
broken so I'd say this is not supported currently. We'll figure it out as we get
on with the dart support.

[dhnishi (use Chromium), 2013-09-10 17:21:37]

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/cc...
File tools/json_schema_compiler/cc_generator.py (right):

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/cc...
tools/json_schema_compiler/cc_generator.py:10: 
On 2013/09/09 23:50:25, kalman wrote:
> now that I know about the Python PEP8 thing, I know that each top-level entity
> (global function, class declaration) should have 2 blank lines between it. So
> you might as well go through and fix those in the files you are touching, too.

Done.

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/da...
File tools/json_schema_compiler/dart_generator_test.py (right):

https://codereview.chromium.org/23549025/diff/1/tools/json_schema_compiler/da...
tools/json_schema_compiler/dart_generator_test.py:64: self._RunTest('enums')
On 2013/09/10 00:53:01, benwells wrote:
> Could you just delete this test and its associated idl file? The output looks
> broken so I'd say this is not supported currently. We'll figure it out as we
get
> on with the dart support.

Done.

[commit-bot: I haz the power, 2013-09-10 17:23:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/DHNishi@gmail.com/23549025/30001

[commit-bot: I haz the power, 2013-09-10 20:49:45]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-09-10 21:56:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/DHNishi@gmail.com/23549025/30001

[commit-bot: I haz the power, 2013-09-10 23:14:05]

Change committed as 222389