[Files.app] Fetch and use CWS OAuth token instead of Drive token in Suggest app dialog.

[Files.app] Fetch and use CWS OAuth token instead of Drive token in Suggest app dialog.

We need to pass the CWS OAuth token to the CWS widget in Suggest app dialog, instead of Drive OAuth token. This patch adds the method to fetch the CWS token and replace the drive token with it in Suggest app dialog.

BUG=none
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222004

[yoshiki, 2013-09-04 05:06:12]

@hirono, could you look at JS file?
@hidehiko, could you look at C++ files?

Thanks.

[hirono, 2013-09-04 05:23:26]

On 2013/09/04 05:06:12, yoshiki wrote:
> @hirono, could you look at JS file?
> @hidehiko, could you look at C++ files?
> 
> Thanks.

lgtm for the JS file.

[hidehiko, 2013-09-04 05:45:07]

https://codereview.chromium.org/23549016/diff/2/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
(right):

https://codereview.chromium.org/23549016/diff/2/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc:310:
SendResponse(false);
FYI: for error handling, setting error_ may be valueable. WDYT?

https://codereview.chromium.org/23549016/diff/2/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_manager/private_api_misc.h (right):

https://codereview.chromium.org/23549016/diff/2/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_manager/private_api_misc.h:128:
FILEBROWSERPRIVATE_ZOOM);
Pls define right enum value.

https://codereview.chromium.org/23549016/diff/2/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/suggest_apps_dialog.js (right):

https://codereview.chromium.org/23549016/diff/2/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/suggest_apps_dialog.js:234:
function(accessToken) {
I think you'd need error handling here.

[yoshiki, 2013-09-04 06:14:58]

@hidehiko, PTAL

https://codereview.chromium.org/23549016/diff/2/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
(right):

https://codereview.chromium.org/23549016/diff/2/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc:310:
SendResponse(false);
On 2013/09/04 05:45:08, hidehiko wrote:
> FYI: for error handling, setting error_ may be valueable. WDYT?

I think passing NULL is enough. Even if Files.app can know the detail of the
error, it can't treat it.

https://codereview.chromium.org/23549016/diff/2/chrome/browser/chromeos/exten...
File chrome/browser/chromeos/extensions/file_manager/private_api_misc.h (right):

https://codereview.chromium.org/23549016/diff/2/chrome/browser/chromeos/exten...
chrome/browser/chromeos/extensions/file_manager/private_api_misc.h:128:
FILEBROWSERPRIVATE_ZOOM);
On 2013/09/04 05:45:08, hidehiko wrote:
> Pls define right enum value.

Oops, Done.

https://codereview.chromium.org/23549016/diff/2/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/suggest_apps_dialog.js (right):

https://codereview.chromium.org/23549016/diff/2/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/suggest_apps_dialog.js:234:
function(accessToken) {
On 2013/09/04 05:45:08, hidehiko wrote:
> I think you'd need error handling here.

I added the handling in show() below.

[hidehiko, 2013-09-04 06:21:40]

lgtm.

[yoshiki, 2013-09-04 06:27:42]

@benwells, could you take a look at file_browser_private.json? Thanks.

[benwells, 2013-09-09 05:00:58]

sorry about the review latency, i've been travelling

lgtm

[commit-bot: I haz the power, 2013-09-09 05:01:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/23549016/12001

[commit-bot: I haz the power, 2013-09-09 05:02:00]

Failed to apply patch for
chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
  Hunk #1 FAILED at 7.
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc.rej

Patch:       chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
Index: chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
index
7b0d066f71c6729fdcb601a45965115e7b5c8352..f021eb9cfa4305f786c82a450c58b2487ddccdfa
100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
@@ -7,20 +7,29 @@
 #include "base/files/file_path.h"
 #include "base/prefs/pref_service.h"
 #include "base/values.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/drive/drive_integration_service.h"
 #include "chrome/browser/chromeos/drive/logging.h"
 #include
"chrome/browser/chromeos/extensions/file_manager/file_manager_installer.h"
 #include "chrome/browser/chromeos/extensions/file_manager/private_api_util.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
+#include "chrome/browser/google_apis/auth_service.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/signin/profile_oauth2_token_service.h"
+#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/common/page_zoom.h"
+#include "google_apis/gaia/oauth2_token_service.h"
 #include "url/gurl.h"
 
 namespace extensions {
 
+namespace {
+const char kCWSScope[] = "https://www.googleapis.com/auth/chromewebstore";
+}
+
 FileBrowserPrivateLogoutUserFunction::FileBrowserPrivateLogoutUserFunction() {
 }
 
@@ -254,4 +263,53 @@ void
FileBrowserPrivateInstallWebstoreItemFunction::OnInstallComplete(
   SendResponse(success);
 }
 
+FileBrowserPrivateRequestWebStoreAccessTokenFunction::
+    FileBrowserPrivateRequestWebStoreAccessTokenFunction() {
+}
+
+FileBrowserPrivateRequestWebStoreAccessTokenFunction::
+    ~FileBrowserPrivateRequestWebStoreAccessTokenFunction() {
+}
+
+bool FileBrowserPrivateRequestWebStoreAccessTokenFunction::RunImpl() {
+  std::vector<std::string> scopes;
+  scopes.push_back(kCWSScope);
+
+  OAuth2TokenService* oauth_service =
+      ProfileOAuth2TokenServiceFactory::GetForProfile(profile());
+  net::URLRequestContextGetter* url_request_context_getter =
+      g_browser_process->system_request_context();
+
+  auth_service_.reset(new google_apis::AuthService(
+      oauth_service,
+      url_request_context_getter,
+      scopes));
+  auth_service_->StartAuthentication(base::Bind(
+      &FileBrowserPrivateRequestWebStoreAccessTokenFunction::
+          OnAccessTokenFetched,
+      this));
+
+  return true;
+}
+
+void
FileBrowserPrivateRequestWebStoreAccessTokenFunction::OnAccessTokenFetched(
+    google_apis::GDataErrorCode code,
+    const std::string& access_token) {
+  if (code == google_apis::HTTP_SUCCESS) {
+    DCHECK(auth_service_->HasAccessToken());
+    DCHECK(access_token == auth_service_->access_token());
+    drive::util::Log(logging::LOG_INFO,
+                     "CWS OAuth token fetch succeeded. (token: %s)",
+                     access_token.c_str());
+    SetResult(new base::StringValue(access_token));
+    SendResponse(true);
+  } else {
+    drive::util::Log(logging::LOG_ERROR,
+                     "CWS OAuth token fetch failed. (GDataErrorCode: %s)",
+                     google_apis::GDataErrorCodeToString(code).c_str());
+    SetResult(base::Value::CreateNullValue());
+    SendResponse(false);
+  }
+}
+
 }  // namespace extensions

[commit-bot: I haz the power, 2013-09-09 05:14:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/23549016/27001

[commit-bot: I haz the power, 2013-09-09 08:12:49]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-09 09:32:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/23549016/47001

[commit-bot: I haz the power, 2013-09-09 11:25:27]

Change committed as 222004