Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 23548030: Style fix of TSFTextStoreTest (Closed)

Created:
7 years, 3 months ago by Yohei Yukawa
Modified:
7 years, 3 months ago
CC:
chromium-reviews, nona+watch_chromium.org, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Style fix of TSFTextStoreTest This CL revises TSFTextStoreTest as follows. - Initialize variables - Declare types in anonymous namespace when possible - Use DISALLOW_COPY_AND_ASSIGN when appropriate - Use scoped_refptr when appropriate There is no behavioral change. BUG=none TEST=ran test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222249

Patch Set 1 : Style fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -81 lines) Patch
M ui/base/ime/win/tsf_text_store_unittest.cc View 40 chunks +112 lines, -81 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Yohei Yukawa
7 years, 3 months ago (2013-09-10 02:20:33 UTC) #1
Seigo Nonaka
lgtm
7 years, 3 months ago (2013-09-10 02:24:30 UTC) #2
yoichio
lgtm
7 years, 3 months ago (2013-09-10 02:31:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/23548030/2001
7 years, 3 months ago (2013-09-10 02:32:26 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 02:53:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Yukawa@chromium.org/23548030/2001
7 years, 3 months ago (2013-09-10 07:16:30 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 11:37:34 UTC) #7
Message was sent while issue was closed.
Change committed as 222249

Powered by Google App Engine
This is Rietveld 408576698