Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 23548023: Add a new component app Guide to Chrome (code name GeniusApp) to replace HelpApp. Add a command lin… (Closed)

Created:
7 years, 3 months ago by davidyu
Modified:
7 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Chi-Ngai Wan, cylee1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a new component app Guide to Chrome (code name GeniusApp) to replace HelpApp. Add a command line switch so that we can easily fall back to the old one if necessary. BUG=chromium:281234 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223006

Patch Set 1 #

Total comments: 6

Patch Set 2 : move resources and switches to chromeos only. use https instead of http. #

Patch Set 3 : move the flag to chromeos_switches.{h,cc}. check the flag in component_loader.cc #

Patch Set 4 : Update manifest.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M chrome/browser/browser_resources.grd View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/chromeos/genius_app/app_id.h View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/genius_app/OWNERS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/genius_app/manifest.json View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
M chrome/browser/ui/chrome_pages.cc View 1 2 3 chunks +19 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
davidyu
Hi Dmitry, manifest.json is not finalized yet, but I would like to send out other ...
7 years, 3 months ago (2013-09-09 10:40:29 UTC) #1
Dmitry Polukhin
https://codereview.chromium.org/23548023/diff/1/chrome/browser/resources/genius_app/manifest.json File chrome/browser/resources/genius_app/manifest.json (right): https://codereview.chromium.org/23548023/diff/1/chrome/browser/resources/genius_app/manifest.json#newcode1 chrome/browser/resources/genius_app/manifest.json:1: { If this app is chromeos specific and you ...
7 years, 3 months ago (2013-09-09 15:42:39 UTC) #2
davidyu
https://codereview.chromium.org/23548023/diff/1/chrome/browser/resources/genius_app/manifest.json File chrome/browser/resources/genius_app/manifest.json (right): https://codereview.chromium.org/23548023/diff/1/chrome/browser/resources/genius_app/manifest.json#newcode1 chrome/browser/resources/genius_app/manifest.json:1: { On 2013/09/09 15:42:39, Dmitry Polukhin wrote: > If ...
7 years, 3 months ago (2013-09-10 00:30:55 UTC) #3
davidyu
add suggested reviewer sky@
7 years, 3 months ago (2013-09-10 00:33:08 UTC) #4
sky
LGTM - but you need an owner for chrome/browser/extensions/component_loader.cc (there are better local owners) and ...
7 years, 3 months ago (2013-09-10 16:14:03 UTC) #5
Dmitry Polukhin
LGTM, chromeos perspective looks fine but please ask extensions OWNERS review before commit
7 years, 3 months ago (2013-09-10 16:52:26 UTC) #6
davidyu
Hi yoz, can you help reviewing chrome/browser/extensions/component_loader.cc? thanks!
7 years, 3 months ago (2013-09-11 00:16:16 UTC) #7
Yoyo Zhou
extensions LGTM
7 years, 3 months ago (2013-09-11 05:04:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidyu@chromium.org/23548023/17001
7 years, 3 months ago (2013-09-13 01:25:31 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-13 04:35:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidyu@chromium.org/23548023/17001
7 years, 3 months ago (2013-09-13 05:25:28 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 08:55:33 UTC) #12
Message was sent while issue was closed.
Change committed as 223006

Powered by Google App Engine
This is Rietveld 408576698