Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 23548021: Web Animations CSS: Add unsigned short to support outline-width (Closed)

Created:
7 years, 3 months ago by Noel Gordon
Modified:
7 years, 3 months ago
Reviewers:
Steve Block
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, Timothy Loh, dstockwell, dglazkov+blink, apavlov+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Web Animations CSS: Add unsigned short to support outline-width Add unsigned short to animatable factory to support outline-width. The test animations/interpolation/outline-width.html no longer crashes when run in the virtual/web-animations-css test suite and no longer overflows to negative values (correctly clamps to unsigned short) so update test expectations for that. Change in behavior here to match Firefox's implementation and align with the CSS spec (outline-width should not be negative). BUG=257591 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157444

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/virtual/web-animations-css/animations/interpolation/outline-width-interpolation-expected.txt View 1 chunk +8 lines, -0 lines 1 comment Download
M Source/core/animation/css/CSSAnimatableValueFactory.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Noel Gordon
7 years, 3 months ago (2013-09-09 07:07:51 UTC) #1
Steve Block
https://codereview.chromium.org/23548021/diff/1/LayoutTests/virtual/web-animations-css/animations/interpolation/outline-width-interpolation-expected.txt File LayoutTests/virtual/web-animations-css/animations/interpolation/outline-width-interpolation-expected.txt (right): https://codereview.chromium.org/23548021/diff/1/LayoutTests/virtual/web-animations-css/animations/interpolation/outline-width-interpolation-expected.txt#newcode2 LayoutTests/virtual/web-animations-css/animations/interpolation/outline-width-interpolation-expected.txt:2: PASS: outline-width from [0px] to [10px] was [0px] at ...
7 years, 3 months ago (2013-09-09 07:38:00 UTC) #2
Noel Gordon
On 2013/09/09 07:38:00, Steve Block wrote: > https://codereview.chromium.org/23548021/diff/1/LayoutTests/virtual/web-animations-css/animations/interpolation/outline-width-interpolation-expected.txt#newcode2 > LayoutTests/virtual/web-animations-css/animations/interpolation/outline-width-interpolation-expected.txt:2: > PASS: outline-width from [0px] ...
7 years, 3 months ago (2013-09-09 07:49:41 UTC) #3
Steve Block
lgtm
7 years, 3 months ago (2013-09-09 07:51:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noel@chromium.org/23548021/1
7 years, 3 months ago (2013-09-09 07:56:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noel@chromium.org/23548021/1
7 years, 3 months ago (2013-09-09 07:57:59 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 08:54:25 UTC) #7
Message was sent while issue was closed.
Change committed as 157444

Powered by Google App Engine
This is Rietveld 408576698