Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3498)

Unified Diff: chrome/browser/resources/options/language_options.js

Issue 23548006: Remove IME related configuration preferences in Chrome OS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/language_options.js
diff --git a/chrome/browser/resources/options/language_options.js b/chrome/browser/resources/options/language_options.js
index 4e8e2fcf1c7113203dd77905c7d2b994b0cd6e7f..ee8d6971652a5e69e99e93c075470ed6757dd580 100644
--- a/chrome/browser/resources/options/language_options.js
+++ b/chrome/browser/resources/options/language_options.js
@@ -9,18 +9,6 @@ cr.define('options', function() {
/** @const */ var OptionsPage = options.OptionsPage;
/** @const */ var LanguageList = options.LanguageList;
- // Some input methods like Chinese Pinyin have config pages.
- // This is the map of the input method names to their config page names.
- /** @const */ var INPUT_METHOD_ID_TO_CONFIG_PAGE_NAME = {
- 'mozc': 'languageMozc',
- 'mozc-chewing': 'languageChewing',
- 'mozc-dv': 'languageMozc',
- 'mozc-hangul': 'languageHangul',
- 'mozc-jp': 'languageMozc',
- 'pinyin': 'languagePinyin',
- 'pinyin-dv': 'languagePinyin',
- };
-
/**
* Spell check dictionary download status.
* @type {Enum}
@@ -173,10 +161,6 @@ cr.define('options', function() {
this.handleVisibleChange_.bind(this));
if (cr.isChromeOS) {
- $('chewing-confirm').onclick = $('hangul-confirm').onclick =
- $('mozc-confirm').onclick = $('pinyin-confirm').onclick =
- OptionsPage.closeOverlay.bind(OptionsPage);
-
this.initializeInputMethodList_();
this.initializeLanguageCodeToInputMethodIdsMap_();
}
@@ -321,15 +305,6 @@ cr.define('options', function() {
var span = element.querySelector('span');
span.textContent = inputMethod.displayName;
- // Add the configure button if the config page is present for this
- // input method.
- if (inputMethod.id in INPUT_METHOD_ID_TO_CONFIG_PAGE_NAME) {
- var pageName = INPUT_METHOD_ID_TO_CONFIG_PAGE_NAME[inputMethod.id];
- var button = this.createConfigureInputMethodButton_(inputMethod.id,
- pageName);
- element.appendChild(button);
- }
-
if (inputMethod.optionsPage) {
var button = document.createElement('button');
button.textContent = loadTimeData.getString('configure');
@@ -348,26 +323,6 @@ cr.define('options', function() {
},
/**
- * Creates a configure button for the given input method ID.
- * @param {string} inputMethodId Input method ID (ex. "pinyin").
- * @param {string} pageName Name of the config page (ex. "languagePinyin").
- * @private
- */
- createConfigureInputMethodButton_: function(inputMethodId, pageName) {
- var button = document.createElement('button');
- button.textContent = loadTimeData.getString('configure');
- button.onclick = function(e) {
- // Prevent the default action (i.e. changing the checked property
- // of the checkbox). The button click here should not be handled
- // as checkbox click.
- e.preventDefault();
- chrome.send('inputMethodOptionsOpen', [inputMethodId]);
- OptionsPage.navigateToPage(pageName);
- };
- return button;
- },
-
- /**
* Adds a language to the preference 'translate_blocked_languages'. If
* |langCode| is already added, nothing happens. |langCode| is converted
* to a Translate language synonym before added.
« no previous file with comments | « chrome/browser/resources/options/chromeos/language_pinyin_options.html ('k') | chrome/browser/resources/options/options.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698