Issue 23547011: Move c/b/extension/api/* into extensions namespace

Issue 23547011: Move c/b/extension/api/* into extensions namespace (Closed)

Created:
7 years, 3 months ago by limasdf

Modified:
7 years, 3 months ago

Reviewers:
miket_OOO, Fady Samuel, James Cook, benjhayden

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Move c/b/extension/api/* into extensions namespace This one moves: - webview - downloads_internal - terminal BUG=117261 TEST=compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223576

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -1 line)			Patch
M	chrome/browser/extensions/api/downloads_internal/downloads_internal_api.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/downloads_internal/downloads_internal_api.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/terminal/terminal_extension_helper.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/terminal/terminal_extension_helper.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/terminal/terminal_private_api.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/terminal/terminal_private_api.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/webview/webview_api.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/webview/webview_api.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 11 (0 generated)

limasdf

Could you review? + benjhayden for download_internal API. + fsamuel for webvview API.

7 years, 3 months ago (2013-09-15 17:50:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/23547011/31001

7 years, 3 months ago (2013-09-16 16:33:22 UTC) #6

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 3 months ago (2013-09-16 17:13:00 UTC) #7

limasdf

Dear jamescook, could you kindly review ui/ash/chrome_shell_delegate_chromeos.cc?

7 years, 3 months ago (2013-09-16 17:28:34 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/23547011/55001

7 years, 3 months ago (2013-09-17 06:05:40 UTC) #10

Message was sent while issue was closed.

Change committed as 223576