Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 23547006: Make ~WebNavigationEventRouter remove itself from browsers (Closed)

Created:
7 years, 3 months ago by sky
Modified:
7 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Make ~WebNavigationEventRouter remove itself from browsers I don't think this is related to the crash I'm seeing, but I noticed it when looking for dangling TabStripModelObservers. BUG=286162 TEST=none R=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221959

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
7 years, 3 months ago (2013-09-06 22:40:16 UTC) #1
Yoyo Zhou
LGTM
7 years, 3 months ago (2013-09-06 22:47:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/23547006/1
7 years, 3 months ago (2013-09-08 02:16:18 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-08 23:44:19 UTC) #4
Message was sent while issue was closed.
Change committed as 221959

Powered by Google App Engine
This is Rietveld 408576698