Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23546007: [rAC, OSX] Namespaced constants. (Closed)

Created:
7 years, 3 months ago by groby-ooo-7-16
Modified:
7 years, 3 months ago
Reviewers:
sail
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[rAC, OSX] Namespaced constants. Keep autofill dialog related constants in named namespace. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221755

Patch Set 1 #

Patch Set 2 : Merge in latest. #

Patch Set 3 : Once more merge to HEAD #

Total comments: 1

Patch Set 4 : Fix namespace comment. #

Messages

Total messages: 7 (0 generated)
groby-ooo-7-16
constant namespacing follow-up - PTAL, depends on OverlayViewController CL.
7 years, 3 months ago (2013-09-04 21:25:46 UTC) #1
groby-ooo-7-16
Now even better, with actual reviewer assigned :) sail: PTAL. This is the constant namespacing ...
7 years, 3 months ago (2013-09-05 00:47:43 UTC) #2
sail
lgtm! https://codereview.chromium.org/23546007/diff/7001/chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h File chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h (right): https://codereview.chromium.org/23546007/diff/7001/chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h#newcode34 chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h:34: } // namespace // namespace autofill
7 years, 3 months ago (2013-09-05 01:12:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/23546007/14001
7 years, 3 months ago (2013-09-05 13:52:46 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=75774
7 years, 3 months ago (2013-09-05 16:27:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/23546007/14001
7 years, 3 months ago (2013-09-06 18:06:48 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 19:38:33 UTC) #7
Message was sent while issue was closed. 
Change committed as 221755

Powered by Google App Engine
This is Rietveld 408576698