Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: tools/telemetry/telemetry/page/page_unittest.py

Issue 23545023: [Telemetry] Add 'name' attribute for pages, which allows for more human-readable printing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgot to update the unitttests :( Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_unittest.py b/tools/telemetry/telemetry/page/page_unittest.py
index 3e068f3e813780278e83defd14588c7e3a5dc575..feca7e00a058e09619a9694cdcc67ddf8d552972 100644
--- a/tools/telemetry/telemetry/page/page_unittest.py
+++ b/tools/telemetry/telemetry/page/page_unittest.py
@@ -57,8 +57,8 @@ class TestPage(unittest.TestCase):
{"url": "http://www.bar.com/"}
]
}, os.path.dirname(__file__))
- self.assertEquals(ps[0].display_url, 'http://www.foo.com/')
- self.assertEquals(ps[1].display_url, 'http://www.bar.com/')
+ self.assertEquals(ps[0].display_name, 'http://www.foo.com/')
+ self.assertEquals(ps[1].display_name, 'http://www.bar.com/')
def testDisplayUrlForHttps(self):
ps = page_set.PageSet.FromDict({
@@ -69,8 +69,8 @@ class TestPage(unittest.TestCase):
{"url": "https://www.bar.com/"}
]
}, os.path.dirname(__file__))
- self.assertEquals(ps[0].display_url, 'http://www.foo.com/')
- self.assertEquals(ps[1].display_url, 'https://www.bar.com/')
+ self.assertEquals(ps[0].display_name, 'http://www.foo.com/')
+ self.assertEquals(ps[1].display_name, 'https://www.bar.com/')
def testDisplayUrlForFile(self):
ps = page_set.PageSet.FromDict({
@@ -81,8 +81,8 @@ class TestPage(unittest.TestCase):
{"url": "file:///../../otherdir/bar.html"},
]
}, os.path.dirname(__file__))
- self.assertEquals(ps[0].display_url, 'foo.html')
- self.assertEquals(ps[1].display_url, 'bar.html')
+ self.assertEquals(ps[0].display_name, 'foo.html')
+ self.assertEquals(ps[1].display_name, 'bar.html')
def testDisplayUrlForFilesDifferingBySuffix(self):
ps = page_set.PageSet.FromDict({
@@ -93,8 +93,8 @@ class TestPage(unittest.TestCase):
{"url": "file:///../../otherdir/foo1.html"},
]
}, os.path.dirname(__file__))
- self.assertEquals(ps[0].display_url, 'foo.html')
- self.assertEquals(ps[1].display_url, 'foo1.html')
+ self.assertEquals(ps[0].display_name, 'foo.html')
+ self.assertEquals(ps[1].display_name, 'foo1.html')
def testDisplayUrlForFileOfDifferentPaths(self):
ps = page_set.PageSet.FromDict({
@@ -105,8 +105,8 @@ class TestPage(unittest.TestCase):
{"url": "file:///../../otherdir/bar.html"},
]
}, os.path.dirname(__file__))
- self.assertEquals(ps[0].display_url, 'somedir/foo.html')
- self.assertEquals(ps[1].display_url, 'otherdir/bar.html')
+ self.assertEquals(ps[0].display_name, 'somedir/foo.html')
+ self.assertEquals(ps[1].display_name, 'otherdir/bar.html')
def testDisplayUrlForFileDirectories(self):
ps = page_set.PageSet.FromDict({
@@ -117,8 +117,8 @@ class TestPage(unittest.TestCase):
{"url": "file:///../../otherdir/bar/"},
]
}, os.path.dirname(__file__))
- self.assertEquals(ps[0].display_url, 'foo')
- self.assertEquals(ps[1].display_url, 'bar')
+ self.assertEquals(ps[0].display_name, 'foo')
+ self.assertEquals(ps[1].display_name, 'bar')
def testDisplayUrlForSingleFile(self):
ps = page_set.PageSet.FromDict({
@@ -128,7 +128,7 @@ class TestPage(unittest.TestCase):
{"url": "file:///../../otherdir/foo.html"},
]
}, os.path.dirname(__file__))
- self.assertEquals(ps[0].display_url, 'foo.html')
+ self.assertEquals(ps[0].display_name, 'foo.html')
def testDisplayUrlForSingleDirectory(self):
ps = page_set.PageSet.FromDict({
@@ -138,4 +138,4 @@ class TestPage(unittest.TestCase):
{"url": "file:///../../otherdir/foo/"},
]
}, os.path.dirname(__file__))
- self.assertEquals(ps[0].display_url, 'foo')
+ self.assertEquals(ps[0].display_name, 'foo')

Powered by Google App Engine
This is Rietveld 408576698