Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py

Issue 23545023: [Telemetry] Add 'name' attribute for pages, which allows for more human-readable printing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgot to update the unitttests :( Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py
diff --git a/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py b/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py
index b9e096f6cf97c67db781365307d1873c9a3824df..dbae9507b6dea3266267ab5a093d2e503534f491 100644
--- a/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py
+++ b/tools/telemetry/telemetry/page/csv_page_measurement_results_unittest.py
@@ -53,7 +53,7 @@ class CsvPageMeasurementResultsTest(unittest.TestCase):
results.DidMeasurePage()
self.assertEquals(
self.output_header_row,
- ['url', 'foo (seconds)'])
+ ['page_name', 'foo (seconds)'])
self.assertEquals(
self.output_data_rows[0],
[self._page_set[0].url, '3'])
@@ -96,11 +96,11 @@ class CsvPageMeasurementResultsTest(unittest.TestCase):
self.assertEquals(
self.output_header_row,
- ['url', 'bar (seconds)', 'foo (seconds)'])
+ ['page_name', 'bar (seconds)', 'foo (seconds)'])
self.assertEquals(
self.output_data_rows,
- [[self._page_set[0].url, '-', '3'],
- [self._page_set[1].url, '4', '-']])
+ [[self._page_set[0].display_name, '-', '3'],
+ [self._page_set[1].display_name, '4', '-']])
def test_histogram(self):
results = NonPrintingCsvPageMeasurementResults(self._output, False)
@@ -120,8 +120,8 @@ class CsvPageMeasurementResultsTest(unittest.TestCase):
self.assertEquals(
self.output_header_row,
- ['url', 'a ()'])
+ ['page_name', 'a ()'])
self.assertEquals(
self.output_data_rows,
- [[self._page_set[0].url, '1.5'],
- [self._page_set[1].url, '2.5']])
+ [[self._page_set[0].display_name, '1.5'],
+ [self._page_set[1].display_name, '2.5']])

Powered by Google App Engine
This is Rietveld 408576698