Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: chrome/test/data/extensions/api_test/activity_log_private/test/test.js

Issue 23545012: [Activity log] Rework extraction of URLs from argument lists (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/activity_log_private/test/test.js
diff --git a/chrome/test/data/extensions/api_test/activity_log_private/test/test.js b/chrome/test/data/extensions/api_test/activity_log_private/test/test.js
index 4e5f4d53dba89e6689a485fd5edc0ec3f580b6eb..162dfcd5ba3b7601defe83d7d4b20a32246be275 100644
--- a/chrome/test/data/extensions/api_test/activity_log_private/test/test.js
+++ b/chrome/test/data/extensions/api_test/activity_log_private/test/test.js
@@ -396,9 +396,14 @@ chrome.activityLogPrivate.onExtensionActivity.addListener(
console.log('Logged:' + apiCall + ' Expected:' + expectedCall);
chrome.test.assertEq(expectedCall, apiCall);
- // Check that no real URLs are logged in incognito-mode tests.
- checkIncognito(activity['pageUrl'], testCases[testCaseIndx].is_incognito);
- checkIncognito(activity['argUrl'], testCases[testCaseIndx].is_incognito);
+ // Check that no real URLs are logged in incognito-mode tests. Ignore
+ // the initial call to windows.create opening the tab.
+ if (apiCall != 'windows.create') {
+ checkIncognito(activity['pageUrl'],
+ testCases[testCaseIndx].is_incognito);
+ checkIncognito(activity['argUrl'],
+ testCases[testCaseIndx].is_incognito);
+ }
// If all the expected calls have been logged for this test case then
// mark as suceeded and move to the next. Otherwise look for the next
« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698