Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 23543010: Stop linking most resources into chrome.dll on windows (Closed)

Created:
7 years, 3 months ago by jamesr
Modified:
6 years, 11 months ago
Reviewers:
tony, cpu_(ooo_6.6-7.5), jam
CC:
chromium-reviews
Visibility:
Public.

Description

Stop linking most resources into chrome.dll on windows We don't actually use these resources, we link and load them into resources.pak. BUG=52609 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220676

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M chrome/chrome_dll.gypi View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
jamesr
This drops the chrome.dll size from 30mb -> 25mb on windows official builds. We've been ...
7 years, 3 months ago (2013-08-30 01:35:25 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
7 years, 3 months ago (2013-08-30 18:11:50 UTC) #2
jam
lgtm
7 years, 3 months ago (2013-08-30 18:23:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/23543010/1
7 years, 3 months ago (2013-08-30 18:25:27 UTC) #4
commit-bot: I haz the power
Failed to trigger a try job on win_rel HTTP Error 400: Bad Request
7 years, 3 months ago (2013-08-30 18:31:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/23543010/16001
7 years, 3 months ago (2013-08-30 18:31:43 UTC) #6
commit-bot: I haz the power
Change committed as 220676
7 years, 3 months ago (2013-08-30 22:18:23 UTC) #7
Nico
Several tests still link in these .rc files – do you know if that's still ...
6 years, 11 months ago (2013-12-31 22:15:01 UTC) #8
tony
6 years, 11 months ago (2014-01-01 02:24:47 UTC) #9
Message was sent while issue was closed.
Nico: It probably depends on the test target.  We should be able to convert all
the tests to use pak files, but we need to make sure to (1) create an
appropriate .pak file to use and (2) load the pak file.

I'll send some more info in a reply to the other emails you sent.

Powered by Google App Engine
This is Rietveld 408576698