Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 23542018: Add default orientation data fetcher. (Closed)

Created:
7 years, 3 months ago by timvolodine
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add default orientation data fetcher. Add support for Device Orientation in the default data fetcher. The default data fetcher is only compiled for platforms where we don't have proper fetchers available, i.e. platforms other than Android, Windows or Mac. BUG=261165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223518

Patch Set 1 #

Patch Set 2 : removed unnecessary includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M content/browser/device_orientation/data_fetcher_shared_memory_default.cc View 1 4 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
timvolodine
7 years, 3 months ago (2013-09-10 14:54:35 UTC) #1
Michael van Ouwerkerk
lgtm
7 years, 3 months ago (2013-09-10 15:05:17 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 3 months ago (2013-09-16 22:29:20 UTC) #3
timvolodine
Hi Peter, please lgtm..
7 years, 3 months ago (2013-09-16 22:32:35 UTC) #4
Peter Beverloo
On 2013/09/16 22:32:35, timvolodine wrote: > Hi Peter, please lgtm.. Lgtm
7 years, 3 months ago (2013-09-16 22:37:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/23542018/4001
7 years, 3 months ago (2013-09-16 22:37:32 UTC) #6
timvolodine
On 2013/09/16 22:37:00, Peter Beverloo wrote: > On 2013/09/16 22:32:35, timvolodine wrote: > > Hi ...
7 years, 3 months ago (2013-09-16 22:44:11 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-16 22:48:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/23542018/4001
7 years, 3 months ago (2013-09-17 00:04:08 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 02:30:03 UTC) #10
Message was sent while issue was closed.
Change committed as 223518

Powered by Google App Engine
This is Rietveld 408576698