Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issue 23542003: Support inputmode using InputScope for Windows8 metro. (Closed)

Created:
7 years, 3 months ago by yoichio
Modified:
7 years, 3 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Support inputmode using InputScope for Windows8 metro. Chrome runs in TSF mode at Windows8 metro. We use COM interface ITextStoreACP::RetrieveRequestedAttrs to tell InputScope to IME in the mode. TSFTextStore, which implements ITextStoreACP, knows target inputmode through TextInputClient::GetTextInputMode and get InputScope using tsf_inputscope::CreateInputScope appending to text input type. RenderWidgetHostViewWin implements TextInputClient::GetTextInputMode. BUG=244688 TEST=Run "chrome --enable-text-services-framework --enable-input-mode-attribute" at windows8 desktop and tests manually using hardware keyboard and onscreen keyboard. Both MS-IME and GoogleJapaneseInput works with hardware keyboard. Unfortunately, onscreen keyboard with MS-IME doesn't work but with GoogleJapaneseIME works. But there might be some issue in onscreen keyboard with MS-IME. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ime/win/tsf_text_store.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
yoichio
Please review.
7 years, 3 months ago (2013-08-28 08:30:33 UTC) #1
Yohei Yukawa
lgtm
7 years, 3 months ago (2013-08-28 08:32:45 UTC) #2
Seigo Nonaka
lgtm
7 years, 3 months ago (2013-08-29 01:05:14 UTC) #3
yoichio
Add sky@ as an OWNER. Could you look at?
7 years, 3 months ago (2013-08-29 01:20:43 UTC) #4
sky
LGTM
7 years, 3 months ago (2013-08-29 15:34:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/23542003/1
7 years, 3 months ago (2013-08-29 23:26:14 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 05:37:56 UTC) #7
Message was sent while issue was closed.
Change committed as 220511

Powered by Google App Engine
This is Rietveld 408576698