Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 23541009: Return Drive mount point by getMountPoints. (Closed)

Created:
7 years, 3 months ago by hidehiko
Modified:
7 years, 3 months ago
Reviewers:
mtomasz, kinaba
CC:
chromium-reviews, rginda+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Return Drive mount point by getMountPoints. By this CL, fileBrowserPrivate.getMountPoints starts to return Drive (if mounted). This is the preparation for getting rid of rootList in DocumentModel. BUG=279276 TEST=Ran unit_tests and tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223614

Patch Set 1 #

Patch Set 2 : Fix browser test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_apitest.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_browser/mount_test/test.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hidehiko
This is based on 23477070 and 23983032, which are LGTM'ed. Thank you for your review ...
7 years, 3 months ago (2013-09-13 03:31:04 UTC) #1
kinaba
lgtm
7 years, 3 months ago (2013-09-13 05:00:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23541009/1
7 years, 3 months ago (2013-09-13 11:57:50 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=154182
7 years, 3 months ago (2013-09-13 14:56:45 UTC) #4
hidehiko
It turned out that I needed to fix a browser test. Tomasz, could you kindly ...
7 years, 3 months ago (2013-09-17 11:33:43 UTC) #5
mtomasz
lgtm for the test
7 years, 3 months ago (2013-09-17 11:35:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/23541009/25001
7 years, 3 months ago (2013-09-17 12:05:14 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 14:46:51 UTC) #8
Message was sent while issue was closed.
Change committed as 223614

Powered by Google App Engine
This is Rietveld 408576698