Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 23539002: Delete app_host from apps/ (Closed)

Created:
7 years, 3 months ago by benwells
Modified:
7 years, 3 months ago
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Delete app_host from apps/ This isn't used any more now and can be deleted. Chrome apps and the chrome app launcher are now part of the main chrome install, and don't need a separate executable to shunt control to chrome. TBR=sky BUG=279671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220555

Patch Set 1 #

Patch Set 2 : Removed from more windows stuff #

Patch Set 3 : Removed TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -645 lines) Patch
D apps/app_host/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D apps/app_host/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D apps/app_host/app_host.rc View 1 chunk +0 lines, -50 lines 0 comments Download
D apps/app_host/app_host_main.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D apps/app_host/app_host_resource.h View 1 chunk +0 lines, -5 lines 0 comments Download
D apps/app_host/binaries_installer.h View 1 chunk +0 lines, -19 lines 0 comments Download
D apps/app_host/binaries_installer.cc View 1 chunk +0 lines, -334 lines 0 comments Download
D apps/app_host/update.h View 1 chunk +0 lines, -16 lines 0 comments Download
D apps/app_host/update.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M apps/apps.gypi View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/app/app_host_exe.ver View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/native_app_window_views.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/mini_installer.gyp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
benwells
7 years, 3 months ago (2013-08-29 05:53:10 UTC) #1
koz (OOO until 15th September)
wew! lgtm
7 years, 3 months ago (2013-08-29 06:05:57 UTC) #2
benwells
There is more stuff in the installer to remove for this but this CL is ...
7 years, 3 months ago (2013-08-29 07:58:10 UTC) #3
Nico
lgtm
7 years, 3 months ago (2013-08-29 17:22:11 UTC) #4
grt (UTC plus 2)
Could you clean up the references to app_host.exe and kChromeAppHostExe in src/chrome/installer/*, and a TODO ...
7 years, 3 months ago (2013-08-30 02:45:15 UTC) #5
grt (UTC plus 2)
On 2013/08/30 02:45:15, grt wrote: > Could you clean up the references to app_host.exe and ...
7 years, 3 months ago (2013-08-30 03:09:44 UTC) #6
benwells
TODO removed. TBR sky for redundant TODO comment removal.
7 years, 3 months ago (2013-08-30 06:39:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/23539002/19001
7 years, 3 months ago (2013-08-30 06:40:35 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 12:03:53 UTC) #9
Message was sent while issue was closed.
Change committed as 220555

Powered by Google App Engine
This is Rietveld 408576698