Issue 23538008: Revert "Do fcntl(...F_FULLFSYNC...) on mac instead of fsync"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23538008: Revert "Do fcntl(...F_FULLFSYNC...) on mac instead of fsync" (Closed)

Created:
7 years, 3 months ago by rmcilroy

Modified:
7 years, 3 months ago

Reviewers:
dgrogan, bulach, rmcilroy_google

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	third_party/leveldatabase/env_chromium.cc	View		2 chunks	+1 line, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

rmcilroy_google

dgrogan: As discussed on bug https://code.google.com/p/chromium/issues/detail?id=286266, I'm reverting this CL due to the performance regressions.

7 years, 3 months ago (2013-09-06 13:57:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/23538008/1

7 years, 3 months ago (2013-09-06 14:06:20 UTC) #3

Message was sent while issue was closed.

Change committed as 221702