Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 23537067: Add support for keyed-call on arrays of fast elements (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1382 matching lines...) Expand 10 before | Expand all | Expand 10 after
1393 LCallNewArray* result = new(zone()) LCallNewArray(context, constructor); 1393 LCallNewArray* result = new(zone()) LCallNewArray(context, constructor);
1394 return MarkAsCall(DefineFixed(result, eax), instr); 1394 return MarkAsCall(DefineFixed(result, eax), instr);
1395 } 1395 }
1396 1396
1397 1397
1398 LInstruction* LChunkBuilder::DoCallFunction(HCallFunction* instr) { 1398 LInstruction* LChunkBuilder::DoCallFunction(HCallFunction* instr) {
1399 LOperand* context = UseFixed(instr->context(), esi); 1399 LOperand* context = UseFixed(instr->context(), esi);
1400 LOperand* function = UseFixed(instr->function(), edi); 1400 LOperand* function = UseFixed(instr->function(), edi);
1401 argument_count_ -= instr->argument_count(); 1401 argument_count_ -= instr->argument_count();
1402 LCallFunction* result = new(zone()) LCallFunction(context, function); 1402 LCallFunction* result = new(zone()) LCallFunction(context, function);
1403 if (instr->IsTailCall()) return DefineFixed(result, eax);
danno 2013/10/11 16:13:24 nit: I think I would it better if you did: LInstr
Toon Verwaest 2013/11/04 13:59:44 Done.
1403 return MarkAsCall(DefineFixed(result, eax), instr); 1404 return MarkAsCall(DefineFixed(result, eax), instr);
1404 } 1405 }
1405 1406
1406 1407
1407 LInstruction* LChunkBuilder::DoCallRuntime(HCallRuntime* instr) { 1408 LInstruction* LChunkBuilder::DoCallRuntime(HCallRuntime* instr) {
1408 argument_count_ -= instr->argument_count(); 1409 argument_count_ -= instr->argument_count();
1409 LOperand* context = UseFixed(instr->context(), esi); 1410 LOperand* context = UseFixed(instr->context(), esi);
1410 return MarkAsCall(DefineFixed(new(zone()) LCallRuntime(context), eax), instr); 1411 return MarkAsCall(DefineFixed(new(zone()) LCallRuntime(context), eax), instr);
1411 } 1412 }
1412 1413
(...skipping 1306 matching lines...) Expand 10 before | Expand all | Expand 10 after
2719 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2720 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2720 LOperand* object = UseRegister(instr->object()); 2721 LOperand* object = UseRegister(instr->object());
2721 LOperand* index = UseTempRegister(instr->index()); 2722 LOperand* index = UseTempRegister(instr->index());
2722 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2723 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2723 } 2724 }
2724 2725
2725 2726
2726 } } // namespace v8::internal 2727 } } // namespace v8::internal
2727 2728
2728 #endif // V8_TARGET_ARCH_IA32 2729 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/ic.h » ('j') | src/ic.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698