Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/browser/password_manager/password_form_manager.cc

Issue 23537029: Save password functionality added to the save password bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review 5 Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_form_manager.cc
diff --git a/chrome/browser/password_manager/password_form_manager.cc b/chrome/browser/password_manager/password_form_manager.cc
index a75b3c8a987633e072a9da020d04b797cd936ed7..fc3ddc232537ae6f625a1c547124cddb9729fc12 100644
--- a/chrome/browser/password_manager/password_form_manager.cc
+++ b/chrome/browser/password_manager/password_form_manager.cc
@@ -40,8 +40,7 @@ PasswordFormManager::PasswordFormManager(Profile* profile,
manager_action_(kManagerActionNone),
user_action_(kUserActionNone),
submit_result_(kSubmitResultNotSubmitted),
- should_save_password_(false),
- should_blacklist_password_(false) {
+ password_action_(DO_NOTHING) {
DCHECK(profile_);
if (observed_form_.origin.is_valid())
base::SplitString(observed_form_.origin.path(), '/', &form_path_tokens_);
@@ -54,8 +53,7 @@ PasswordFormManager::~PasswordFormManager() {
kMaxNumActionsTaken);
// In case the tab is closed before the next navigation occurs this will
// apply outstanding changes.
- if (should_save_password_ || should_blacklist_password_)
- ApplyChange();
+ ApplyChange();
}
int PasswordFormManager::GetActionsTaken() {
@@ -113,23 +111,11 @@ bool PasswordFormManager::DoesManage(const PasswordForm& form,
}
void PasswordFormManager::ApplyChange() {
- DCHECK(!should_blacklist_password_ || !should_save_password_);
- if (should_save_password_)
+ if (password_action_ == SAVE)
Save();
- else if (should_blacklist_password_)
+ else if (password_action_ == BLACKLIST)
PermanentlyBlacklist();
- should_blacklist_password_ = false;
- should_save_password_ = false;
-}
-
-void PasswordFormManager::SavePassword() {
- should_blacklist_password_ = false;
- should_save_password_ = true;
-}
-
-void PasswordFormManager::BlacklistPassword() {
- should_save_password_ = false;
- should_blacklist_password_ = true;
+ password_action_ = DO_NOTHING;
}
bool PasswordFormManager::IsBlacklisted() {

Powered by Google App Engine
This is Rietveld 408576698