Issue 23537022: Add navigation controls to DevTools screencast view

Issue 23537022: Add navigation controls to DevTools screencast view (Closed)

Created:
7 years, 3 months ago by Vladislav Kaznacheev

Modified:
7 years, 3 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add navigation controls to DevTools screencast view BUG=285169 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157452

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed comments #

Patch Set 3 : Polished styles, added icons #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -0 lines)			Patch
M	Source/core/inspector/InspectorPageAgent.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/inspector/InspectorPageAgent.cpp	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/devtools/devtools.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/ScreencastView.js	View	1 2	3 chunks	+77 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/screencastView.css	View	1 2	1 chunk	+61 lines, -0 lines	0 comments	Download
M	Source/devtools/protocol.json	View	1 2	2 chunks	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/23537022/diff/1/Source/devtools/front_end/ScreencastView.js File Source/devtools/front_end/ScreencastView.js (right): https://codereview.chromium.org/23537022/diff/1/Source/devtools/front_end/ScreencastView.js#newcode80 Source/devtools/front_end/ScreencastView.js:80: WebInspector.ScreencastView.HTTP_REGEXP = /^https?:\/\/(.+)/; HttpRegex https://codereview.chromium.org/23537022/diff/1/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/23537022/diff/1/Source/devtools/protocol.json#newcode189 ...

7 years, 3 months ago (2013-09-05 11:34:12 UTC) #3

Vladislav Kaznacheev

PTAL https://codereview.chromium.org/23537022/diff/1/Source/devtools/front_end/ScreencastView.js File Source/devtools/front_end/ScreencastView.js (right): https://codereview.chromium.org/23537022/diff/1/Source/devtools/front_end/ScreencastView.js#newcode80 Source/devtools/front_end/ScreencastView.js:80: WebInspector.ScreencastView.HTTP_REGEXP = /^https?:\/\/(.+)/; Renamed to _HttpRegex On 2013/09/05 ...

7 years, 3 months ago (2013-09-05 12:53:55 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/23537022/22001

7 years, 3 months ago (2013-09-09 10:33:02 UTC) #6

Message was sent while issue was closed.

Change committed as 157452

Expand Messages | Collapse Messages