Issue 23537020: Fixes FileSystemOperation::Cancel behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23537020: Fixes FileSystemOperation::Cancel behavior (Closed)

Created:
7 years, 3 months ago by kinuko

Modified:
7 years, 3 months ago

Reviewers:
tzik

CC:
chromium-reviews, nhiroki+watch_chromium.org, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes FileSystemOperation::Cancel behavior When a cancel is requested for in-flight Truncate operation, we don't (can't) stop running the Truncate, let it run until the end, but then return following values: - ABORT error for Truncate (while it hasn't been really aborted) - OK for the cancel operation (while the operation hasn't been really canceled) This feels weird since the cancel wasn't actually processed. Instead this CL changes the return values: - The original status code for Truncate - INVALID_OPERATION for the cancel operation unles the original status code is ABORT I verified that this doesn't break existing JS behavior. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221443

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -6 lines)			Patch
M	chrome/browser/sync_file_system/local/syncable_file_operation_runner_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_impl.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	webkit/browser/fileapi/file_system_operation_runner_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kinuko

Separated out from https://codereview.chromium.org/23898002/. PTL

7 years, 3 months ago (2013-09-05 08:12:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23537020/1

7 years, 3 months ago (2013-09-05 11:29:11 UTC) #3

Message was sent while issue was closed.

Change committed as 221443

Expand Messages | Collapse Messages