Issue 23537019: Don't try to load an event page to fire an event if the browser is shutting down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23537019: Don't try to load an event page to fire an event if the browser is shutting down. (Closed)

Created:
7 years, 3 months ago by Jeffrey Yasskin

Modified:
7 years, 3 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Don't try to load an event page to fire an event if the browser is shutting down. BUG=276610 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221311

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	chrome/browser/extensions/lazy_background_task_queue.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/extensions/lazy_background_task_queue.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Jeffrey Yasskin

I wasn't totally sure whether to call the task with NULL or just drop the ...

7 years, 3 months ago (2013-09-04 02:37:16 UTC) #1

Matt Perry

LGTM I agree, running with NULL seems like the right thing here.

7 years, 3 months ago (2013-09-04 19:36:16 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/23537019/1

7 years, 3 months ago (2013-09-04 20:14:24 UTC) #3

Message was sent while issue was closed.

Change committed as 221311