Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: components/autofill/content/browser/wallet/wallet_client_unittest.cc

Issue 23537014: rAc: Get rid of dialog type in rAc, there is only one type left now. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/wallet/wallet_client_unittest.cc
diff --git a/components/autofill/content/browser/wallet/wallet_client_unittest.cc b/components/autofill/content/browser/wallet/wallet_client_unittest.cc
index 858b1d4515a74376018569ef524ba131ceef6c1a..2ef1bb0d8b00f737c7dfa7c92837f2c6a327347c 100644
--- a/components/autofill/content/browser/wallet/wallet_client_unittest.cc
+++ b/components/autofill/content/browser/wallet/wallet_client_unittest.cc
@@ -581,11 +581,9 @@ class MockAutofillMetrics : public AutofillMetrics {
MOCK_CONST_METHOD2(LogWalletApiCallDuration,
void(WalletApiCallMetric metric,
const base::TimeDelta& duration));
- MOCK_CONST_METHOD2(LogWalletErrorMetric,
- void(DialogType dialog_type, WalletErrorMetric metric));
- MOCK_CONST_METHOD2(LogWalletRequiredActionMetric,
- void(DialogType dialog_type,
- WalletRequiredActionMetric action));
+ MOCK_CONST_METHOD1(LogWalletErrorMetric, void(WalletErrorMetric metric));
+ MOCK_CONST_METHOD1(LogWalletRequiredActionMetric,
+ void(WalletRequiredActionMetric action));
private:
DISALLOW_COPY_AND_ASSIGN(MockAutofillMetrics);
};
@@ -602,10 +600,6 @@ class MockWalletClientDelegate : public WalletClientDelegate {
return metric_logger_;
}
- virtual DialogType GetDialogType() const OVERRIDE {
- return DIALOG_TYPE_REQUEST_AUTOCOMPLETE;
- }
-
virtual std::string GetRiskData() const OVERRIDE {
return "risky business";
}
@@ -630,25 +624,19 @@ class MockWalletClientDelegate : public WalletClientDelegate {
}
void ExpectWalletErrorMetric(AutofillMetrics::WalletErrorMetric metric) {
- EXPECT_CALL(
- metric_logger_,
- LogWalletErrorMetric(
- DIALOG_TYPE_REQUEST_AUTOCOMPLETE, metric)).Times(1);
+ EXPECT_CALL(metric_logger_, LogWalletErrorMetric(metric)).Times(1);
}
void ExpectWalletRequiredActionMetric(
AutofillMetrics::WalletRequiredActionMetric metric) {
- EXPECT_CALL(
- metric_logger_,
- LogWalletRequiredActionMetric(
- DIALOG_TYPE_REQUEST_AUTOCOMPLETE, metric)).Times(1);
+ EXPECT_CALL(metric_logger_,
+ LogWalletRequiredActionMetric(metric)).Times(1);
}
void ExpectBaselineMetrics() {
EXPECT_CALL(
metric_logger_,
LogWalletErrorMetric(
- DIALOG_TYPE_REQUEST_AUTOCOMPLETE,
AutofillMetrics::WALLET_ERROR_BASELINE_ISSUED_REQUEST))
.Times(1);
ExpectWalletRequiredActionMetric(

Powered by Google App Engine
This is Rietveld 408576698