Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

Issue 23537014: rAc: Get rid of dialog type in rAc, there is only one type left now. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
index 07547bb096eeab28265ee048406413c3a0245c34..8b1e84d22a1c21134717868cea436e2264204efc 100644
--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
@@ -21,8 +21,6 @@
#include "components/autofill/content/browser/autofill_driver_impl.h"
#include "components/autofill/core/common/autofill_messages.h"
#include "components/autofill/core/common/autofill_pref_names.h"
-#include "content/public/browser/navigation_details.h"
-#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents_view.h"
#include "ui/gfx/rect.h"
@@ -89,7 +87,6 @@ void TabAutofillManagerDelegate::ConfirmSaveCreditCard(
void TabAutofillManagerDelegate::ShowRequestAutocompleteDialog(
const FormData& form,
const GURL& source_url,
- DialogType dialog_type,
const base::Callback<void(const FormStructure*,
const std::string&)>& callback) {
HideRequestAutocompleteDialog();
@@ -97,7 +94,6 @@ void TabAutofillManagerDelegate::ShowRequestAutocompleteDialog(
dialog_controller_ = AutofillDialogController::Create(web_contents_,
form,
source_url,
- dialog_type,
callback);
if (dialog_controller_) {
dialog_controller_->Show();
@@ -167,13 +163,7 @@ void TabAutofillManagerDelegate::DidNavigateMainFrame(
if (!dialog_controller_.get())
return;
- bool was_redirect = details.entry &&
- content::PageTransitionIsRedirect(details.entry->GetTransitionType());
-
- if (dialog_controller_->GetDialogType() == DIALOG_TYPE_REQUEST_AUTOCOMPLETE ||
- !was_redirect) {
- HideRequestAutocompleteDialog();
- }
+ HideRequestAutocompleteDialog();
}
void TabAutofillManagerDelegate::WebContentsDestroyed(

Powered by Google App Engine
This is Rietveld 408576698