Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1863)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

Issue 23537014: rAc: Get rid of dialog type in rAc, there is only one type left now. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
index 1f88e9f20abf6aeab3e7a734214334bb107e6026..ddb60c24ffcc8757fd6a83245bd67a20e3bc2bf1 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
@@ -211,8 +211,7 @@ class TestAccountChooserModel : public AccountChooserModel {
TestAccountChooserModel(AccountChooserModelDelegate* delegate,
PrefService* prefs,
const AutofillMetrics& metric_logger)
- : AccountChooserModel(delegate, prefs, metric_logger,
- DIALOG_TYPE_REQUEST_AUTOCOMPLETE) {}
+ : AccountChooserModel(delegate, prefs, metric_logger) {}
virtual ~TestAccountChooserModel() {}
using AccountChooserModel::kActiveWalletItemId;
@@ -231,20 +230,17 @@ class TestAutofillDialogController
const FormData& form_structure,
const GURL& source_url,
const AutofillMetrics& metric_logger,
- const DialogType dialog_type,
const base::Callback<void(const FormStructure*,
const std::string&)>& callback,
MockNewCreditCardBubbleController* mock_new_card_bubble_controller)
: AutofillDialogControllerImpl(contents,
form_structure,
source_url,
- dialog_type,
callback),
metric_logger_(metric_logger),
mock_wallet_client_(
Profile::FromBrowserContext(contents->GetBrowserContext())->
GetRequestContext(), this),
- dialog_type_(dialog_type),
mock_new_card_bubble_controller_(mock_new_card_bubble_controller) {}
virtual ~TestAutofillDialogController() {}
@@ -271,12 +267,6 @@ class TestAutofillDialogController
const GURL& open_tab_url() { return open_tab_url_; }
- virtual DialogType GetDialogType() const OVERRIDE {
- return dialog_type_;
- }
-
- void set_dialog_type(DialogType dialog_type) { dialog_type_ = dialog_type; }
-
void SimulateSigninError() {
OnWalletSigninError();
}
@@ -328,7 +318,6 @@ class TestAutofillDialogController
TestPersonalDataManager test_manager_;
testing::NiceMock<wallet::MockWalletClient> mock_wallet_client_;
GURL open_tab_url_;
- DialogType dialog_type_;
MockNewCreditCardBubbleController* mock_new_card_bubble_controller_;
DISALLOW_COPY_AND_ASSIGN(TestAutofillDialogController);
@@ -418,7 +407,6 @@ class AutofillDialogControllerTest : public ChromeRenderViewHostTestHarness {
form_data,
GURL(),
metric_logger_,
- DIALOG_TYPE_REQUEST_AUTOCOMPLETE,
callback,
mock_new_card_bubble_controller_.get()))->AsWeakPtr();
controller_->Init(profile());

Powered by Google App Engine
This is Rietveld 408576698