chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h - Issue 23537014: rAc: Get rid of dialog type in rAc, there is only one type left now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h

Issue 23537014: rAc: Get rid of dialog type in rAc, there is only one type left now. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/risk/fingerprint_browsertest.cc ('k') | chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h

diff --git a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h

index e59cecbd56ed07fc830d3f1f1e51eda3810d6ec5..03d609dbde191d9ba53519c00ac2c0449449c5ce 100644

--- a/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h

+++ b/chrome/browser/ui/android/autofill/autofill_dialog_controller_android.h

@@ -30,7 +30,6 @@ class AutofillDialogControllerAndroid : public AutofillDialogController {

content::WebContents* contents,

const FormData& form_structure,

const GURL& source_url,

- const DialogType dialog_type,

const base::Callback<void(const FormStructure*,

const std::string&)>& callback);

@@ -43,7 +42,6 @@ class AutofillDialogControllerAndroid : public AutofillDialogController {

virtual void Show() OVERRIDE;

virtual void Hide() OVERRIDE;

virtual void TabActivated() OVERRIDE;

- virtual DialogType GetDialogType() const OVERRIDE;

// JNI bindings for Java-side AutofillDialogDelegate:

void DialogCancel(JNIEnv* env, jobject obj);

@@ -64,7 +62,6 @@ class AutofillDialogControllerAndroid : public AutofillDialogController {

content::WebContents* contents,

const FormData& form_structure,

const GURL& source_url,

- const DialogType dialog_type,

const base::Callback<void(const FormStructure*,

const std::string&)>& callback);

@@ -92,9 +89,6 @@ class AutofillDialogControllerAndroid : public AutofillDialogController {

base::Time dialog_shown_timestamp_;

AutofillMetrics::DialogInitialUserStateMetric initial_user_state_;

- // Whether this is an Autocheckout or a requestAutocomplete dialog.

- const DialogType dialog_type_;

FormStructure form_structure_;

// Whether the URL visible to the user when this dialog was requested to be