Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 23536047: Files.app: Move the error handler to the top of combined script. (Closed)

Created:
7 years, 3 months ago by hirono
Modified:
7 years, 3 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Files.app: Move the error handler to the top of combined script. Currently the error handler to count uncaught errors is set in the file_manager.js. This CL moved the error handler to the top of combined script, which enable us to catch the uncaught erros that is raised before the file_manager.js is loaded. BUG=none TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223603

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
A chrome/browser/resources/file_manager/js/error_counter.js View 1 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/resources/file_manager/js/main_scripts.js View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hirono
Could you check the CL? Thank you very much!
7 years, 3 months ago (2013-09-13 16:22:26 UTC) #1
yoshiki
main_script.js is not loaded when the 'flattening' is disabled. Instead, how about moving it to ...
7 years, 3 months ago (2013-09-17 04:04:33 UTC) #2
hirono
On 2013/09/17 04:04:33, yoshiki wrote: > main_script.js is not loaded when the 'flattening' is disabled. ...
7 years, 3 months ago (2013-09-17 05:43:47 UTC) #3
yoshiki
On 2013/09/17 05:43:47, hirono wrote: > On 2013/09/17 04:04:33, yoshiki wrote: > > main_script.js is ...
7 years, 3 months ago (2013-09-17 05:54:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/23536047/14001
7 years, 3 months ago (2013-09-17 06:32:41 UTC) #5
hirono
Fixed. Thank you!
7 years, 3 months ago (2013-09-17 06:32:44 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-17 06:40:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/23536047/14001
7 years, 3 months ago (2013-09-17 07:05:30 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 13:16:13 UTC) #9
Message was sent while issue was closed.
Change committed as 223603

Powered by Google App Engine
This is Rietveld 408576698