Issue 23536038: Minor feedback UI fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23536038: Minor feedback UI fixes. (Closed)

Created:
7 years, 3 months ago by rkc

Modified:
7 years, 3 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Minor feedback UI fixes. This CL fixes the attached file 'size to big' error to show the maximum size allowed. Also reduced the size of the screenshot (when zoomed) slightly because on some platforms it doesn't fit into the feedback page width, displacing all the elements and moving one line down. R=xiyuan@chromium.org BUG=285993 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221890

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/app/generated_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/resources/feedback/css/feedback.css	View		2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/23536038/1

7 years, 3 months ago (2013-09-07 01:19:45 UTC) #3

Message was sent while issue was closed.

Change committed as 221890

Expand Messages | Collapse Messages