Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 23536025: Added vtune profiler. (Closed)

Created:
7 years, 3 months ago by shatch
Modified:
7 years, 3 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add vtune profiler support on linux. BUG= TEST=./tools/perf/run_measurement --browser=release page_cycler tools/perf/page_sets/tough_layout_cases.json --page-filter=amar --pageset-repeat=2 --profiler=vtune Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221333

Patch Set 1 #

Total comments: 8

Patch Set 2 : Changes from review. #

Patch Set 3 : Changes from review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -0 lines) Patch
A tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py View 1 2 1 chunk +112 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
shatch
7 years, 3 months ago (2013-09-04 18:11:47 UTC) #1
tonyg
lgtm https://codereview.chromium.org/23536025/diff/1/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py File tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py (right): https://codereview.chromium.org/23536025/diff/1/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py#newcode23 tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py:23: stdout=self._tmp_output_file, stderr=subprocess.STDOUT) funny indentation here https://codereview.chromium.org/23536025/diff/1/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py#newcode36 tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py:36: # ...
7 years, 3 months ago (2013-09-04 18:16:03 UTC) #2
shatch
New snapshot uploaded. https://codereview.chromium.org/23536025/diff/1/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py File tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py (right): https://codereview.chromium.org/23536025/diff/1/tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py#newcode23 tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py:23: stdout=self._tmp_output_file, stderr=subprocess.STDOUT) On 2013/09/04 18:16:03, tonyg ...
7 years, 3 months ago (2013-09-04 20:30:41 UTC) #3
shatch
New snapshot uploaded, ptal.
7 years, 3 months ago (2013-09-04 20:49:37 UTC) #4
tonyg
lgtm
7 years, 3 months ago (2013-09-04 21:03:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/23536025/10001
7 years, 3 months ago (2013-09-04 21:06:49 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=75538
7 years, 3 months ago (2013-09-05 00:19:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/23536025/10001
7 years, 3 months ago (2013-09-05 00:21:25 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 03:09:22 UTC) #9
Message was sent while issue was closed.
Change committed as 221333

Powered by Google App Engine
This is Rietveld 408576698