[ash] Hide tooltip when mouse button is pressed

[ash] Hide tooltip when mouse button is pressed

Hiding tooltip when mouse button is pressed was done in launcher view.
It looks more better when tooltip manager handles.

R=skuhne@chromium.org
BUG=NONE
TEST=ash_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221208

[simonhong_, 2013-09-03 02:24:16]

Dear Stefan,
Please take a look.

[Mr4D (OOO till 08-26), 2013-09-03 15:00:27]

Nice!

Could you please check if we have a unit test which checks this with the
TooltipManager? If it does not exist yet - please add one!

https://codereview.chromium.org/23536012/diff/1/ash/launcher/launcher_tooltip...
File ash/launcher/launcher_tooltip_manager.cc (right):

https://codereview.chromium.org/23536012/diff/1/ash/launcher/launcher_tooltip...
ash/launcher/launcher_tooltip_manager.cc:259: // When mouse button is pressed in
anywhere, tooltip should to be closed.
Could you change the comment to something like:

Pressing the mouse button anywhere should close the tooltip.

?

[simonhong_, 2013-09-04 00:41:01]

Dear stafan,
I added unit test for press event.
Please check again!

https://codereview.chromium.org/23536012/diff/1/ash/launcher/launcher_tooltip...
File ash/launcher/launcher_tooltip_manager.cc (right):

https://codereview.chromium.org/23536012/diff/1/ash/launcher/launcher_tooltip...
ash/launcher/launcher_tooltip_manager.cc:259: // When mouse button is pressed in
anywhere, tooltip should to be closed.
On 2013/09/03 15:00:27, Mr4D wrote:
> Could you change the comment to something like:
> 
> Pressing the mouse button anywhere should close the tooltip.
> 
> ?

Done.

[Mr4D (OOO till 08-26), 2013-09-04 03:21:47]

lgtm

Thanks for adding the test!

https://codereview.chromium.org/23536012/diff/9001/ash/launcher/launcher_tool...
File ash/launcher/launcher_tooltip_manager_unittest.cc (right):

https://codereview.chromium.org/23536012/diff/9001/ash/launcher/launcher_tool...
ash/launcher/launcher_tooltip_manager_unittest.cc:247: 
Please add a comment for what the test does.

[simonhong_, 2013-09-04 04:18:17]

Thank you for review!

https://codereview.chromium.org/23536012/diff/9001/ash/launcher/launcher_tool...
File ash/launcher/launcher_tooltip_manager_unittest.cc (right):

https://codereview.chromium.org/23536012/diff/9001/ash/launcher/launcher_tool...
ash/launcher/launcher_tooltip_manager_unittest.cc:247: 
On 2013/09/04 03:21:47, Mr4D wrote:
> Please add a comment for what the test does.

Done.

[commit-bot: I haz the power, 2013-09-04 04:18:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/23536012/16001

[commit-bot: I haz the power, 2013-09-04 17:05:44]

Change committed as 221208