For iOS, don't override VALID_ARCHS in Debug configuration.

For iOS, don't override VALID_ARCHS in Debug configuration.

When Xcode recognizes a device, it sets the active arch to the arch of
the device. Since the Debug configuration is set to only compile for the
active arch, Xcode was failing to build when an iPhone 5 was connected
because that device uses armv7s which is not in the list of VALID_ARCHS.

This CL uses the default value of VALID_ARCHS for Debug so that Xcode
will build no matter what device is connected.

This CL also moves the arch-twiddling into an OS=="ios" block to make it
clear that the configurations are only needed for iOS.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222625

[Mark Mentovai, 2013-09-06 17:38:44]

LGTM. Check the comment and also get Rohit’s review.

https://codereview.chromium.org/23535007/diff/3001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/23535007/diff/3001/build/common.gypi#newcode4680
build/common.gypi:4680: 'VALID_ARCHS': 'armv7 i386',
Is this supposed to be a space-separated string instead of a list?

[lliabraa, 2013-09-06 18:12:40]

https://codereview.chromium.org/23535007/diff/3001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/23535007/diff/3001/build/common.gypi#newcode4680
build/common.gypi:4680: 'VALID_ARCHS': 'armv7 i386',
On 2013/09/06 17:38:44, Mark Mentovai wrote:
> Is this supposed to be a space-separated string instead of a list?

Yep

[rohitrao (ping after 24h), 2013-09-06 18:59:44]

lgtm

[commit-bot: I haz the power, 2013-09-11 17:11:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lliabraa@chromium.org/23535007/3001

[commit-bot: I haz the power, 2013-09-11 20:49:24]

Change committed as 222625