Issue 23534062: Fix Views blue button's blurry text on Aura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23534062: Fix Views blue button's blurry text on Aura. (Closed)

Created:
7 years, 3 months ago by msw

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, Evan Stade, benwells

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Views blue button's blurry text on Aura. Views::BlueButton text was appearing blurry in Aura. (View::AddChildViewAt fires PropagateNativeThemeChanged) Make LabelButton::ResetColorsFromNativeTheme virtual. Override in BlueButton subclass with needed colors. See before/after pics at http://crbug.com/274657#c11 BUG=274657 TEST=Blue button text does not appear blurry on Win/CrOS Aura. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223640

Patch Set 1 #

Patch Set 2 : Only disable blue button sub-pixel anti-aliasing on Aura. #

Patch Set 3 : Make LabelButton::ResetColorsFromNativeTheme virtual; override for BlueButton. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
M	ui/views/controls/button/blue_button.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/controls/button/blue_button.cc	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
M	ui/views/controls/button/label_button.h	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/views/controls/button/label_button.cc	View	1 2	4 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/23534062/11001

7 years, 3 months ago (2013-09-17 16:11:35 UTC) #3

Message was sent while issue was closed.

Change committed as 223640

Expand Messages | Collapse Messages