Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 23534051: Add Pepper flag to UMA plugin records. (Closed)

Created:
7 years, 3 months ago by meacer
Modified:
7 years, 3 months ago
CC:
chromium-reviews, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Add Pepper flag to UMA plugin records. BUG=285440 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/metrics/metrics_log.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/metrics/proto/system_profile.proto View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
meacer
Ilya, can you please take a look? Thanks.
7 years, 3 months ago (2013-09-04 23:28:15 UTC) #1
Ilya Sherman
LG, but per protocol, please get the protobuf changes approved internally first. I can show ...
7 years, 3 months ago (2013-09-05 00:15:06 UTC) #2
Mustafa Acer
On 2013/09/05 00:15:06, Ilya Sherman wrote: > LG, but per protocol, please get the protobuf ...
7 years, 3 months ago (2013-09-05 00:18:07 UTC) #3
Ilya Sherman
On 2013/09/05 00:18:07, Mustafa Acer wrote: > On 2013/09/05 00:15:06, Ilya Sherman wrote: > > ...
7 years, 3 months ago (2013-09-05 00:38:47 UTC) #4
meacer
On 2013/09/05 00:38:47, Ilya Sherman wrote: > On 2013/09/05 00:18:07, Mustafa Acer wrote: > > ...
7 years, 3 months ago (2013-09-05 00:46:24 UTC) #5
Ilya Sherman
LGTM, thanks.
7 years, 3 months ago (2013-09-09 19:23:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/23534051/1
7 years, 3 months ago (2013-09-09 19:38:06 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 01:59:23 UTC) #8
Message was sent while issue was closed.
Change committed as 222179

Powered by Google App Engine
This is Rietveld 408576698