RootWindowController::GetFullscreenWindow() should return the active one.

RootWindowController::GetFullscreenWindow() should return the active one.

It returned the fullscreen window (if any) in the active workspace,
and a workspace could contain only one fullscreen window at most.
However, now there's only one desktop workspace which can contain
multiple fullscreen windows.

To follow the past state, it would be better to return the active
fullscreen window first.

TEST=covered by ash_unittests
R=oshima@chromium.org, sky@chromium.org
BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221602

[oshima, 2013-09-04 23:45:55]

https://chromiumcodereview.appspot.com/23534049/diff/1/ash/root_window_contro...
File ash/root_window_controller.cc (right):

https://chromiumcodereview.appspot.com/23534049/diff/1/ash/root_window_contro...
ash/root_window_controller.cc:515: return child;
Given that multiple fullscreen / immersive windows co-exist in one root window,
and non fullscreen window can overlap on top of it, I think you need to get top
most fullscreen wnidow.

Would you also mind renaming this GetTopmostFullscreenWindow ?

[Jun Mukai, 2013-09-05 00:04:09]

https://chromiumcodereview.appspot.com/23534049/diff/1/ash/root_window_contro...
File ash/root_window_controller.cc (right):

https://chromiumcodereview.appspot.com/23534049/diff/1/ash/root_window_contro...
ash/root_window_controller.cc:515: return child;
On 2013/09/04 23:45:55, oshima wrote:
> Given that multiple fullscreen / immersive windows co-exist in one root
window,
> and non fullscreen window can overlap on top of it, I think you need to get
top
> most fullscreen wnidow.
> 
> Would you also mind renaming this GetTopmostFullscreenWindow ?

Done.

[oshima, 2013-09-05 00:09:18]

lgtm

[Jun Mukai, 2013-09-05 04:21:03]

+sky for the change of chrome/browser/fullscreen_chromeos.cc

[sky, 2013-09-05 16:21:59]

LGTM with the following change

https://codereview.chromium.org/23534049/diff/6001/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/23534049/diff/6001/ash/root_window_controller...
ash/root_window_controller.cc:506: for (int i = container->children().size() -
1; i >= 0; --i) {
How about a reverse iterator so I don't have to worry about overflow?

[Jun Mukai, 2013-09-05 18:30:52]

https://codereview.chromium.org/23534049/diff/6001/ash/root_window_controller.cc
File ash/root_window_controller.cc (right):

https://codereview.chromium.org/23534049/diff/6001/ash/root_window_controller...
ash/root_window_controller.cc:506: for (int i = container->children().size() -
1; i >= 0; --i) {
On 2013/09/05 16:21:59, sky wrote:
> How about a reverse iterator so I don't have to worry about overflow?

Done.

[commit-bot: I haz the power, 2013-09-05 18:32:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/23534049/14001

[commit-bot: I haz the power, 2013-09-05 20:36:53]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-05 20:40:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/23534049/16001

[commit-bot: I haz the power, 2013-09-06 06:22:09]

Change committed as 221602